regular expression in "dependsOnMethods" not work

[missedone]

hi, cbeust

I read the user guide

Both dependsOnGroups and dependsOnMethods accept regular expressions as parameters.

so i tried to use regular expression in "dependsOnMethods", for example:

@Test
public void testMethod1() {...};

@Test
public void testMethod2() {...};

@Test (dependsOnMethods="test.*")
public void testMethod3() {...};

but i got an error below:

org.testng.TestNGException:
example.testMethod3() depends on nonexistent method test.*
at org.testng.internal.MethodHelper.findDependedUponMethods(MethodHelper.java:98)

though the workaround is quit straightforward, just let you know this issue.
thanks

[wutingbupt]

Hi missedone,

From the source code, I see that test ng using Pattern.matches(regexp, methodName) to check if current method should be invoked.

At there, the methodName is like "package name.classname. methodname"
so your regular pattern can not match this, you can add your package name and class name in this pattern, or using
.test.

Brs,
Tim

[wutingbupt]

I think using find is better compared with matches.

@cbeust Do you have any comments for this problem?

[freddy33]

Using TestNG 6.8

Hi liked this feature, looked good on the user guides but:

• Liked described here using "test." send:
  org.testng.TestNGException:
  org.artifactory.storage.db.build.BuildsTest.fullDelete() depends on nonexistent method test.
  at org.testng.internal.MethodHelper.findDependedUponMethods(MethodHelper.java:114)
  at org.testng.internal.MethodHelper.topologicalSort(MethodHelper.java:240)
  at org.testng.internal.MethodHelper.sortMethods(MethodHelper.java:317)
  at org.testng.internal.MethodHelper.collectAndOrderMethods(MethodHelper.java:59)
  at org.testng.TestRunner.initMethods(TestRunner.java:481)
• Using ".BuildsTest.test." send:
  java.lang.NullPointerException
  at org.testng.DependencyMap.getMethodDependingOn(DependencyMap.java:54)
  at org.testng.TestRunner.createDynamicGraph(TestRunner.java:1068)
  at org.testng.TestRunner.privateRun(TestRunner.java:734)
  at org.testng.TestRunner.run(TestRunner.java:617)
  at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
  at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329)
  at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291)
  at org.testng.SuiteRunner.run(SuiteRunner.java:240)
  at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
  at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
  at org.testng.TestNG.runSuitesSequentially(TestNG.java:1198)
  at org.testng.TestNG.runSuitesLocally(TestNG.java:1123)
  at org.testng.TestNG.run(TestNG.java:1031)
• Using ".test." send:
  org.testng.TestNGException:
  The following methods have cyclic dependencies:
  BuildsTest.fullDelete()[pri:0, instance:org.artifactory.storage.db.build.BuildsTest@34f7dd13]
  at org.testng.internal.Graph.topologicalSort(Graph.java:148)
  at org.testng.internal.MethodHelper.topologicalSort(MethodHelper.java:261)
  at org.testng.internal.MethodHelper.sortMethods(MethodHelper.java:317)
  at org.testng.internal.MethodHelper.collectAndOrderMethods(MethodHelper.java:59)
  at org.testng.TestRunner.initMethods(TestRunner.java:481)
  at org.testng.TestRunner.init(TestRunner.java:235)
  at org.testng.TestRunner.init(TestRunner.java:205)
  at org.testng.TestRunner.(TestRunner.java:160)

Looks like I'll need to dive into the code for having what I need ;)

[syntastical]

yeah this still seems broken.
I'm getting Method "DatadogLogTests.asdf()[pri:0, instance:XXX]" depends on nonexistent method "Test_C[0-9]{7}"

And my test looks like

    @Test(dependsOnMethods = "Test_C[0-9]{7}")
    public void asdf() {
        System.out.println("test");
    }
    @Test
    public void Test_C6390323() { ... }

[krmahadevan]

@syntastical you tried in version 7.6.1 correct?

[syntastical]

@krmahadevan yeah we're on 7.6.1. The problem seems to be around https://github.com/cbeust/testng/blob/cd85bcb7afebbaecd2299cbc72632e27f89a441b/testng-core/src/main/java/org/testng/DependencyMap.java#L56

When it gets here "methodName" is the regex Test_C[0-9]{7} and it cannot match the dependencies in the List.

[krmahadevan]

@syntastical - Would you be willing to help file a pull request for this (Since you seem to have spent time and effort in debugging this)? We can help you get it reviewed/merged.