Bump gradle version to 7.3.3 to support java17 build #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shoothzj - all the tests failed. Can you please check ? |
Since I am first contributor, can't manualy check tests. |
|
@krmahadevan Shoud I retry the tests? :) |
krmahadevan
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
@juherr - Once you are fine with the changes, can we merge this PR?
@shoothzj - Nah. We are good. We have some flaky tests in the codebase (which need to be fixed and doesn't have anything to do with your PR). Thank you so much for taking the time to raise this PR. Appreciate it and hope to see more contributions coming from you 👍 |
juherr
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you remember to?
CHANGES.txt./gradlew autostyleApply