Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix possibilty that AfterGroups method is invoked before all tests #2753

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

velma
Copy link
Contributor

@velma velma commented Apr 24, 2022

Fixes #2754
When AfterGroups method has multiple groups defined then situation was possible that it is invoked not after all tests for all its groups but after the last test of any group

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

for defined groups are invoked, in case when AfterGrouos method has
multiple groups defined
CHANGES.txt Outdated Show resolved Hide resolved
@krmahadevan
Copy link
Member

@juherr can you please help take a quick look ?

@juherr juherr merged commit 28d0fd4 into testng-team:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@AfterGroups is executed for each "finished" group when it has multiple groups defined
3 participants