Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add friendly name to config #29

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Add friendly name to config #29

merged 1 commit into from
Apr 12, 2024

Conversation

tetele
Copy link
Owner

@tetele tetele commented Apr 12, 2024

Although defined as a substitution, the friendly_name was missing from esphome.

According to this, the implications were concerning components defined with name: None

Should fix #18

@tetele tetele added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Apr 12, 2024
@tetele tetele merged commit c88c59c into main Apr 12, 2024
1 of 2 checks passed
@tetele tetele deleted the friendly-name-fix branch April 12, 2024 09:22
@tetele tetele mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using as TTS device in Home Assistant
1 participant
@tetele