Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pre-fetch of envoy #136

Closed
codefromthecrypt opened this issue Mar 26, 2021 · 1 comment
Closed

Remove pre-fetch of envoy #136

codefromthecrypt opened this issue Mar 26, 2021 · 1 comment
Labels
tech debt

Comments

@codefromthecrypt
Copy link
Contributor

Describe the bug
If you don't know what version is needed, or prefetch the wrong version of envoy, tests will fail like this in CI

2021-03-26T01:54:20.965069Z	error	Unable to start Envoy process: fork/exec /home/circleci/.getenvoy/builds/standard/1.11.0/linux_glibc/bin/envoy: text file busy

To Reproduce

remove this line or change the version in circleci config

      - run: go run cmd/getenvoy/main.go fetch standard:1.11.0

Expected behavior

It is expected to not have to guess versions or do commands like this.

Additional context
https://app.circleci.com/pipelines/github/tetratelabs/getenvoy/604/workflows/8dbaf2ac-1872-44b7-951c-1fd4b514f4f3/jobs/1160
@codefromthecrypt codefromthecrypt added bug Something isn't working tech debt labels Mar 26, 2021
@codefromthecrypt codefromthecrypt mentioned this issue Mar 26, 2021
Merged
@codefromthecrypt codefromthecrypt removed the bug Something isn't working label Mar 26, 2021
@codefromthecrypt
Copy link
Contributor Author

no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codefromthecrypt