Moves lint and format to make, managed by bingo #132
Conversation
| @@ -0,0 +1,12 @@ | |||
|
|
|||
There was a problem hiding this comment.
NOTE: files in .bingo are generated, so you can ignore them
.golangci.yml
Outdated
| - initClause | ||
| - methodExprCall | ||
| - nilValReturn | ||
| - octalLiteral | ||
| - offBy1 |
There was a problem hiding this comment.
removed all these lines to get rid of redundant warnings in output
pkg/binary/envoy/config.go
Outdated
| @@ -97,7 +97,7 @@ func (r *Runtime) SaveConfig(name, config string) (string, error) { | |||
| return "", fmt.Errorf("Unable to create directory %q: %v", configDir, err) | |||
| } | |||
| filename := name + ".yaml" | |||
| err := ioutil.WriteFile(filepath.Join(configDir, filename), []byte(config), 0644) | |||
| err := ioutil.WriteFile(filepath.Join(configDir, filename), []byte(config), 0600) | |||
There was a problem hiding this comment.
new version of the sec linter is more strict. I went with the advice instead of ignoring it.
codefromthecrypt
force-pushed
the
bingo
branch
2 times, most recently
from
3a21b59 to
f8365f3
Compare
codefromthecrypt
changed the title
|
@mathetake can you disable circleci? I finished the almost done migration here https://app.circleci.com/settings/project/github/tetratelabs/getenvoy |
.github/workflows/commit.yaml
Outdated
|
|
||
| jobs: | ||
| check: |
There was a problem hiding this comment.
these two were from circleci
|
some kooky stuff in tests like this. I'll get to the bottom of it.. |
This statement is simply not true:
|
This removes a few shell scripts and in the process updates linters to more current versions. For example, we were using golangci from 2019. To adjust, some invalid statements were removed. The main part of this change is using https://github.com/bwplotka/bingo as the linters we used were go programs anyway. Bingo generates make entries you can use to on-demang install tools without affecting your go.mod and without shell scripts. Co-authored-by: Takeshi Yoneda <takeshi@tetrate.io> Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
changed the title
|
rebased over the go 1.16 PR and removed the circleci related changes |
|
failure seems to repeat. will look into it.. |
Signed-off-by: Adrian Cole <adrian@tetrate.io>
|
opened #136 about the strange test dep on a hard-coded envoy version |
|
FYI "Run unit tests on Linux" is stale.. this is a known issue when you have added GH actions then remove it on the same PR. It still shows up in the output. |
|
thanks for helping @mathetake |
This removes a few shell scripts and in the process updates linters to
more current versions. For example, we were using golangci from 2019. To
adjust, some invalid statements were removed.
This also adds goimport formatting, used by some of our other projects.
The main part of this change is using https://github.com/bwplotka/bingo
as the linters we used were go programs anyway. Bingo generates make
entries you can use to on-demang install tools without affecting your
go.mod and without shell scripts.
Fixes #131