-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates consistently to go 1.16 #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, depending on CI, one ran go 1.13 and the other 1.16. This centralizes to 1.16 in efforts to remove differences between local and CI runs (as well differences between CI). This is needed anyway for future change. Signed-off-by: Adrian Cole <adrian@tetrate.io>
mathetake
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the lint failure here is fixed in #132 so I'll move this change into that one |
I'll fix here because migrating off circleci isn't going to be quick |
Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
go1.16
branch
from
March 25, 2021 09:12
2828b91
to
ed8f620
Compare
there's a panic in the output. I'll look into it tomorrow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, depending on CI, one ran go 1.13 and the other 1.16. This
centralizes to 1.16 in efforts to remove differences between local and
CI runs (as well differences between CI). This is needed anyway for
future change.
Signed-off-by: Adrian Cole adrian@tetrate.io