Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates consistently to go 1.16 #133

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Updates consistently to go 1.16 #133

merged 3 commits into from
Mar 26, 2021

Conversation

codefromthecrypt
Copy link
Contributor

Before, depending on CI, one ran go 1.13 and the other 1.16. This
centralizes to 1.16 in efforts to remove differences between local and
CI runs (as well differences between CI). This is needed anyway for
future change.

Signed-off-by: Adrian Cole adrian@tetrate.io

Before, depending on CI, one ran go 1.13 and the other 1.16. This
centralizes to 1.16 in efforts to remove differences between local and
CI runs (as well differences between CI). This is needed anyway for
future change.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codefromthecrypt
Copy link
Contributor Author

the lint failure here is fixed in #132 so I'll move this change into that one

@codefromthecrypt
Copy link
Contributor Author

I'll fix here because migrating off circleci isn't going to be quick

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt
Copy link
Contributor Author

there's a panic in the output. I'll look into it tomorrow

--- FAIL: Test_capture (0.39s)
    --- FAIL: Test_capture/creates_non-empty_access_and_error_log_files (0.39s)
        log_linux_test.go:38: error stating /home/circleci/.getenvoy/debug/1616663621906226331/logs/access.log: stat /home/circleci/.getenvoy/debug/1616663621906226331/logs/access.log: no such file or directory
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x89adb1]

goroutine 53 [running]:
testing.tRunner.func1.2(0x908360, 0xce3ee0)
	/usr/local/go/src/testing/testing.go:1144 +0x332
testing.tRunner.func1(0xc0004ee180)
	/usr/local/go/src/testing/testing.go:1147 +0x4b6
panic(0x908360, 0xce3ee0)
	/usr/local/go/src/runtime/panic.go:965 +0x1b9
github.com/tetratelabs/getenvoy/pkg/binary/envoy/debug.Test_capture.func1(0xc0004ee180)
	/home/circleci/project/pkg/binary/envoy/debug/log_linux_test.go:40 +0x391
testing.tRunner(0xc0004ee180, 0x9b8378)
	/usr/local/go/src/testing/testing.go:1194 +0xef
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1239 +0x2b3
FAIL	github.com/tetratelabs/getenvoy/pkg/binary/envoy/debug	0.855s

@codefromthecrypt codefromthecrypt merged commit 250d093 into master Mar 26, 2021
@codefromthecrypt codefromthecrypt deleted the go1.16 branch March 26, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants