Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default Wasm runtime to Envoy 1.17 from wasm:1.15 #114

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

nullpo-head
Copy link
Contributor

Wasm plugin has been introduced in Envoy 1.17, so we're working on migrating the GetEnvoy's default Envoy version for Wasm from the wasm: 1.15 branch to 1.17.
This PR changes the default Envoy version for Wasm templates to standard:1.17.0.

This PR depends on tetratelabs/envoy-wasm-rust-sdk#67`. This PR should be merged after it's completed.

Signed-off-by: Takaya Saeki <takaya@tetrate.io>
@nullpo-head nullpo-head marked this pull request as ready for review March 5, 2021 02:28
Signed-off-by: Takaya Saeki <takaya@tetrate.io>
@nullpo-head
Copy link
Contributor Author

Hi @liamawhite and @yskopets , could you review this PR to update the default version of Envoy for wasm runtime to 1.17, please? The migration to Envoy 1.17 of the Rust SDK side is resumed and completed, so I'd like to update GetEnvoy's default version. Please let me know if there's anyone else who I should ask to review.

Copy link
Member

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

One approval is enough to merge.

@mathetake mathetake merged commit 5ceed06 into tetratelabs:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants