Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch extension config file based on languages #125

Merged
merged 14 commits into from
Mar 25, 2021
Merged

Switch extension config file based on languages #125

merged 14 commits into from
Mar 25, 2021

Conversation

mathetake
Copy link
Member

Signed-off-by: Takeshi Yoneda takeshi@tetrate.io

ref #124

@mathetake
Switch extension config file based on languages
9e7ebe9 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Add tests for README substitution
f273429 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Ignore comment lines
4d0ddf3 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Fix lint error
6a7706a 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
nolint to fsRegistry.Get
b5420fc 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Fix e2e
d6cd859 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake marked this pull request as ready for review March 22, 2021 12:40
@mathetake
Copy link
Member Author

@yskopets, @arkodg, @musaprg @nullpo-head PTAL when you have time 🙂

yskopets
yskopets requested changes Mar 23, 2021
View reviewed changes
Copy link
Member

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

I'd like to ask to avoid interpreting the contents of extension.txt in getenvoy. What's inside that file should be completely up to extension developers.

Sorry if I wasn't clear earlier.

pkg/extension/workspace/model/example.go Outdated Show resolved Hide resolved
.../example/runtime/configdir/testdata/workspace8/expected/getenvoy_extension_run/extension.txt Outdated Show resolved Hide resolved
data/example/init/templates/envoy.access_loggers/default/README.md Outdated Show resolved Hide resolved
data/example/init/templates/envoy.filters.http/default/README.md Outdated Show resolved Hide resolved
data/example/init/templates/envoy.filters.network/default/README.md Outdated Show resolved Hide resolved
pkg/extension/workspace/example/runtime/configdir/configdir.go Outdated Show resolved Hide resolved
pkg/extension/example/init/registry/global.go Outdated Show resolved Hide resolved
...example/runtime/configdir/testdata/workspace1/expected/getenvoy_extension_run/extension.json Outdated Show resolved Hide resolved
pkg/extension/example/init/registry/types.go Outdated Show resolved Hide resolved
data/example/init/templates/configurations/extension.txt Outdated Show resolved Hide resolved
@mathetake
review: part1
7e830c7 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Copy link
Member Author

I'd like to ask to avoid interpreting the contents of extension.txt in getenvoy. What's inside that file should be completely up to extension developers.
Sorry if I wasn't clear earlier.

Now I understand your earlier comment. Thanks. On it.

@mathetake
README substitution.
090e447 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Lint
f11a985 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
fix comment
395b4a2 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Ignore comment lines in the Go SDK examples
b6833cc 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake requested a review from yskopets March 24, 2021 02:46
@mathetake
Copy link
Member Author

@yskopets PTAL!

@mathetake
Update GO SDK
ceac28b 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
review
d1fe069 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
remove unnecessary empty lines
410b3c1 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake merged commit 5c46136 into master Mar 25, 2021
@mathetake mathetake deleted the tinygo-config branch March 25, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yskopets yskopets yskopets approved these changes

@arkodg arkodg Awaiting requested review from arkodg

@musaprg musaprg Awaiting requested review from musaprg

@nullpo-head nullpo-head Awaiting requested review from nullpo-head

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @yskopets