Fixes lint setup to skip embedded tinygo examples #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <adrian@tetrate.io>
| @@ -141,6 +132,7 @@ issues: | |||
| - errcheck | |||
| - dupl | |||
| - gosec | |||
| - lll | |||
There was a problem hiding this comment.
tests tend to have really long lines
| @@ -39,7 +39,7 @@ var ( | |||
| ) | |||
|
|
|||
| // NewToolchain returns a builtin toolchain with a given configuration. | |||
| func NewToolchain(name string, cfg *config.ToolchainConfig, workspace model.Workspace) *builtin { | |||
| func NewToolchain(name string, cfg *config.ToolchainConfig, workspace model.Workspace) *builtin { //nolint | |||
There was a problem hiding this comment.
the lint error is that returning unexported types is confusing. I feel it probably isn't unexpected here, so disabled it.
| # from this option's value: | ||
| # vendor$, third_party$, testdata$, examples$, Godeps$, builtin$ | ||
| skip-dirs: | ||
| - pkg/binary/envoytest |
There was a problem hiding this comment.
I took out the skip-dirs thing from here as it is handled externally. we aren't vendoring anything and addressing or ignoring the lint problems in envoytest was imho a better call than the confusion of two things doing skip-dir (make and here)
mathetake
approved these changes
Mar 26, 2021
|
Added #139 to discuss linting of templates in general |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adrian Cole adrian@tetrate.io