Restricts default make config to single-entry GOPATH #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
force-pushed
the
less-fuss
branch
from
43ea2c4
to
f7debe7
Compare
Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
less-fuss
branch
from
f7debe7
to
a09011d
Compare
codefromthecrypt
changed the title
|
This takes the windows runner performance down from 7m to 4m! |
Merged
|
merging as I don't expect any pushback, but don't mind revisions later either! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restricts the default make config to single-entry GOPATH, which allows windows to work without hacks or cygwin.
Those who must use multiple-entry GOPATH will have to override GOBIN if they use our Makefile
See bwplotka/bingo#26
This defers porting to go 1.17 #314