Allows wasip1 guests to use arbitrarily nested pre-opens #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes composite filesystem support only used for guests compiled with `GOOS=js`. Now, these guests have mount a root path and do any composition externally (such as via symlinks or composing `fs.FS`). Removing our composite filesystem reduces maintenance and allows `wasip1` guests to use any paths they want. Before, we had a composite filesystem adapter, allowing wasm compiled by Go's `GOOS=js` to emulate pre-opens. This implementation was incomplete, preventing mounts like "/usr/bin" to work in wasip1. `GOOS=js` is both experimental and will be removed after Go 1.22 is released (two versions of its alternative `GOOS=wasip1`). Fixes #1525 Signed-off-by: Adrian Cole <adrian@tetrate.io>
This was referenced Jun 26, 2023
mathetake
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes composite filesystem support only used for guests compiled with
GOOS=js. Now, these guests have mount a root path and do any composition externally (such as via symlinks or composingfs.FS).Removing our composite filesystem reduces maintenance and allows
wasip1guests to use any paths they want.Before, we had a composite filesystem adapter, allowing wasm compiled by Go's
GOOS=jsto emulate pre-opens. This implementation was incomplete, preventing mounts like "/usr/bin" to work in wasip1.GOOS=jsis both experimental and will be removed after Go 1.22 is released (two versions of its alternativeGOOS=wasip1).Fixes #1525