sysfs: Makes ReadFS and AdaptFS embeddable #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exports the experimental `sysfs.ReadFS` and `sysfs.AdaptFS` types, to developers can choose to embed them. This makes certain decoration use cases easier. Note: We can't do the same without a risk of drift in `sysfs.DirFS`, but that isn't likely a problem as people are used to `os.DirFS` which also doesn't export its type. Signed-off-by: Adrian Cole <adrian@tetrate.io>
| @@ -419,9 +419,9 @@ func validateMounts(mounts sliceFlag, stdErr logging.Writer) (rc int, rootPath s | |||
| fmt.Fprintf(stdErr, "invalid mount: path %q is not a directory\n", dir) | |||
| } | |||
|
|
|||
| root := sysfs.NewDirFS(dir) | |||
| root := sysfs.DirFS(dir) | |||
There was a problem hiding this comment.
reamed to be more like os.DirFS
| @@ -80,11 +70,6 @@ func (UnimplementedFS) Utimens(path string, atim, mtim int64) Errno { | |||
| return ENOSYS | |||
| } | |||
|
|
|||
| // Truncate implements FS.Truncate | |||
| func (UnimplementedFS) Truncate(string, int64) Errno { | |||
There was a problem hiding this comment.
fuzz as we removed this from FS a while ago
evacchi
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exports the experimental
sysfs.ReadFSandsysfs.AdaptFStypes, to developers can choose to embed them. This makes certain decoration use cases easier.Note: We can't do the same without a risk of drift in
sysfs.DirFS, but that isn't likely a problem as people are used toos.DirFSwhich also doesn't export its type.