Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jit(arm64): support call instruction #221

Merged
merged 32 commits into from
Feb 14, 2022
Merged

jit(arm64): support call instruction #221

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
ff0fb35
backfill
mathetake Feb 10, 2022
73bf9b5
wip
mathetake Feb 10, 2022
8f5b341
del
mathetake Feb 10, 2022
64c4fd6
simplify
mathetake Feb 10, 2022
ac789dc
simplify
mathetake Feb 10, 2022
0c1265b
done?
mathetake Feb 10, 2022
a52d136
fix
mathetake Feb 10, 2022
02cfd95
Fix readInstructionAddress.
mathetake Feb 10, 2022
8f8a2c7
more
mathetake Feb 10, 2022
d950455
simple
mathetake Feb 10, 2022
d05deff
fix
mathetake Feb 10, 2022
a929a51
implement return
mathetake Feb 12, 2022
cfc4db7
Merge remote-tracking branch 'origin/main' into call
mathetake Feb 12, 2022
8e0df70
done for returnFunction
mathetake Feb 12, 2022
45334aa
modify
mathetake Feb 12, 2022
85f834d
more
mathetake Feb 12, 2022
4f54f6a
add test
mathetake Feb 12, 2022
85536d5
not segfault
mathetake Feb 12, 2022
0911925
ok
mathetake Feb 12, 2022
abe2adb
ok
mathetake Feb 13, 2022
1410d5c
Merge remote-tracking branch 'origin/main' into call
mathetake Feb 13, 2022
8eaefee
remove e2e
mathetake Feb 13, 2022
442a3c0
com
mathetake Feb 13, 2022
39b63ff
more
mathetake Feb 14, 2022
c6e7292
more
mathetake Feb 14, 2022
9fa4f1d
more
mathetake Feb 14, 2022
91ca6ca
more
mathetake Feb 14, 2022
c3de32e
Apply suggestions from code review
mathetake Feb 14, 2022
ea249ca
explicit
mathetake Feb 14, 2022
c402f28
word
mathetake Feb 14, 2022
6a7eb6c
should be on comma
mathetake Feb 14, 2022
e341c43
fix
mathetake Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions wasm/jit/jit_arm64.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ func (c *arm64Compiler) returnFunction() error {
// At this point, we have
//
// [......., ra.caller, rb.caller, rc.caller, _, ra.current, rb.current, rc.current, _, ...] <- call frame stack's data region (somewhere in the memory)
// ^
// ^
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this should be on comma as this points to the address of a struct, not any specific field.

// callFrameStackTopAddressRegister
// (absolute address of &callFrameStack[engine.callFrameStackPointer])
//
Expand Down Expand Up @@ -672,7 +672,7 @@ func (c *arm64Compiler) callFunction(addr wasm.FunctionAddress, functype *wasm.F
// At this point, we have:
//
// [..., ra.current, rb.current, rc.current, _, ra.next, rb.next, rc.next, ...] <- call frame stack's data region (somewhere in the memory)
// ^
// ^
// callFrameStackTopAddressRegister
// (absolute address of &callFrame[engine.callFrameStackPointer]])
//
Expand Down