Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in the cache example test function name #2238

Merged
merged 1 commit into from
Jun 8, 2024
Merged

fix typo in the cache example test function name #2238

merged 1 commit into from
Jun 8, 2024

Conversation

syumai
Copy link
Contributor

@syumai syumai commented Jun 8, 2024

In the cache example test, the function newRuntimeCompileClose had a doc comment named: newRuntimeCompileDestroy.

@syumai syumai requested a review from mathetake as a code owner June 8, 2024 01:14
@syumai
fix typo in the cache example test function name
1287bf1 
Signed-off-by: Shuichiro Fukuoka <syumai@gmail.com>
mathetake
mathetake approved these changes Jun 8, 2024
View reviewed changes
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ncruces ncruces merged commit 981e71d into tetratelabs:main Jun 8, 2024
64 checks passed
@syumai syumai deleted the fix-typo-chache-example-test branch June 10, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syumai @mathetake @ncruces