Fix fibonacci example in Readme
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
approved these changes
Feb 12, 2022
There was a problem hiding this comment.
Thanks for the help! indeed we drifted this.. unless we switch to asciidoc I think drift is likely for a while and we'll have to be more careful. Thanks for the help!
Usually I don't tend to put full imports an example, but I can see why this is helpful as it clarifies more than I would have guessed. 👍
PS Later, we'll revise the text a little as there's no need to talk about TinyGo for fibonacci as that's implementable easy enough in the text format. We'll delay that until our compiler is complete, so no action needed now!
|
Thanks @r8d8! |
r8d8
added a commit
to r8d8/wazero
that referenced
this pull request
Feb 14, 2022
Signed-off-by: r8d8 <ckryvomaz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.