Removes CustomSection except NameSection #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per #232, we will be unexporting fields only used during instantiate. Any additional custom sections are unusable otherwise, so this skips them. In doing so, this eliminates a length check bug, some TODO and some logic that enforced strict name uniqueness even though that only rule only applied to the name section. Note: this doesn't restrict future use of custom sections, ex for DWARF, just we don't buffer sections we don't use anymore. See https://www.w3.org/TR/wasm-core-1/#custom-section%E2%91%A0 Signed-off-by: Adrian Cole <adrian@tetrate.io>
mathetake
reviewed
Feb 14, 2022
| // * SectionIDType returns the count of FunctionType | ||
| // * SectionIDCustom returns one if the NameSection is present | ||
| // * SectionIDExport returns the count of unique export names | ||
| func (m *Module) SectionElementCount(sectionID SectionID) uint32 { // element as in vector elements! |
mathetake
approved these changes
Feb 14, 2022
|
Thanks for the peek fellas |
r8d8
pushed a commit
to r8d8/wazero
that referenced
this pull request
Feb 14, 2022
Per tetratelabs#232, we will be unexporting fields only used during instantiate. Any additional custom sections are unusable otherwise, so this skips them. In doing so, this eliminates a length check bug, some TODO and some logic that enforced strict name uniqueness even though that only rule only applied to the name section. Note: this doesn't restrict future use of custom sections, ex for DWARF, just we don't buffer sections we don't use anymore. See https://www.w3.org/TR/wasm-core-1/#custom-section%E2%91%A0 Signed-off-by: Adrian Cole <adrian@tetrate.io> Signed-off-by: r8d8 <ckryvomaz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #232, we will be unexporting fields only used during instantiate. Any
additional custom sections are unusable otherwise, so this skips them.
In doing so, this eliminates a length check bug, some TODO and some
logic that enforced strict name uniqueness even though that only rule
only applied to the name section.
Note: this doesn't restrict future use of custom sections, ex for DWARF,
just we don't buffer sections we don't use anymore.
See https://www.w3.org/TR/wasm-core-1/#custom-section%E2%91%A0