Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jit(arm64): Add common 'compile'/'maybeCompile' prefix #235

Merged
merged 2 commits into from
Feb 14, 2022
Merged

jit(arm64): Add common 'compile'/'maybeCompile' prefix #235

merged 2 commits into from
Feb 14, 2022

Conversation

mathetake
Copy link
Member

exception are popValueOnRegister, popTwoValuesOnRegisters and allocateRegister and they are left with TODO

@mathetake
jit(arm64): Add commone 'compile'/'maybeCompile' prefix
dddb79c 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake changed the title jit(arm64): Add commone 'compile'/'maybeCompile' prefix jit(arm64): Add common 'compile'/'maybeCompile' prefix Feb 14, 2022
@mathetake
Copy link
Member Author

amd64 is messy to enforce this as-is, so I will do that in another PR

@mathetake
range
646a6b5 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
codefromthecrypt
codefromthecrypt approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@mathetake mathetake merged commit 059bf1c into main Feb 14, 2022
@mathetake mathetake deleted the prefix branch February 14, 2022 04:14
r8d8 pushed a commit to r8d8/wazero that referenced this pull request Feb 14, 2022
@mathetake @r8d8
jit(arm64): Add common 'compile'/'maybeCompile' prefix (tetratelabs#235)
7011653 
Signed-off-by: r8d8 <ckryvomaz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @codefromthecrypt