Makes filesystem test simpler and removes use of panic in examples #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,11 +12,11 @@ func main() { | |||
| for s.Scan() { | |||
| line := s.Text() | |||
| if _, err := fmt.Printf("Hello, %s!\n", strings.TrimSpace(line)); err != nil { | |||
| panic(err) | |||
| os.Exit(1) | |||
There was a problem hiding this comment.
IIRC when we wrote these examples, we didn't implement exit, yet
|
I will raise a PR to document the WASIConfig because I think it is easy to forget arg[0] is the program name. In this case, I think it probably makes sense to default it to the WASM module name, but we can discuss on that PR. |
mathetake
approved these changes
Mar 19, 2022
Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
simpler-examples
branch
from
c7046e8 to
4c4ac12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces size of #394 so that when finished, it is easier to review.