-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support non-http schemas in url refs #75
Conversation
These url schemes were already valid for inline linking. This adds the ability to use them as url references as well.
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
===========================================
+ Coverage 98.83% 100.00% +1.16%
===========================================
Files 11 12 +1
Lines 1206 1199 -7
Branches 221 222 +1
===========================================
+ Hits 1192 1199 +7
+ Misses 14 0 -14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself is fine for me, thanks for the contribution.
But I see, that the regular expression pattern is compiled on every function call, we can move this to the constructor, where all the other patterns are compiled as well, to gain some performance.
I'll add that change as well. Thank you. |
These url schemes were already valid for inline linking. This adds
the ability to use them as url references as well.