Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-http schemas in url refs #75

Merged
merged 5 commits into from
Mar 13, 2021

Conversation

alts
Copy link

@alts alts commented Mar 5, 2021

These url schemes were already valid for inline linking. This adds
the ability to use them as url references as well.

ikirudennis and others added 4 commits June 8, 2019 12:32
These url schemes were already valid for inline linking. This adds
the ability to use them as url references as well.
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #75 (6b787c9) into master (23e7746) will increase coverage by 1.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #75      +/-   ##
===========================================
+ Coverage   98.83%   100.00%   +1.16%     
===========================================
  Files          11        12       +1     
  Lines        1206      1199       -7     
  Branches      221       222       +1     
===========================================
+ Hits         1192      1199       +7     
+ Misses         14         0      -14     
Impacted Files Coverage Δ
textile/core.py 100.00% <100.00%> (+1.88%) ⬆️
textile/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e7746...6b787c9. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 5, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 6b787c9 on alts:url-ref-schemas into 23e7746 on textile:master.

@textile textile deleted a comment from coveralls Mar 7, 2021
Copy link
Member

@sebix sebix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is fine for me, thanks for the contribution.

But I see, that the regular expression pattern is compiled on every function call, we can move this to the constructor, where all the other patterns are compiled as well, to gain some performance.

@alts
Copy link
Author

alts commented Mar 7, 2021

But I see, that the regular expression pattern is compiled on every function call, we can move this to the constructor, where all the other patterns are compiled as well, to gain some performance.

I'll add that change as well. Thank you.

@alts alts requested a review from sebix March 7, 2021 22:34
@sebix sebix requested a review from ikirudennis March 9, 2021 20:59
@ikirudennis ikirudennis changed the base branch from master to develop March 13, 2021 18:19
@ikirudennis ikirudennis merged commit 1f7a33c into textile:develop Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants