Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong output when "bc.." is the last block #81 #82

Merged
merged 22 commits into from
Aug 5, 2024

Conversation

kpot
Copy link

@kpot kpot commented Aug 31, 2022

Passed all tests. Basically I just re-used the same code that was handling (inside the "for" loop) a closure of a previous extended block before the next block could be processed.

@ikirudennis ikirudennis changed the base branch from master to develop August 5, 2024 18:39
@ikirudennis ikirudennis changed the base branch from develop to master August 5, 2024 18:46
@ikirudennis
Copy link
Member

Apologies for the delay. I completely forgot this was here.

I typically add new work to the develop branch. It looks like there might be some conflicts if I do that directly, so I think I'll try creating a separate branch to merge these changes into, and then I'll work on merging it into develop and then eventually into master.

Thanks for putting the work into this!

@ikirudennis ikirudennis changed the base branch from master to feature/pr82 August 5, 2024 18:57
@ikirudennis ikirudennis merged commit 89310f3 into textile:feature/pr82 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants