Fix index iterator #565
Merged
Fix index iterator #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sanderpick
commented
Oct 29, 2021
sanderpick
commented
- Fixes index iterator panic
- Adds a flag to skip thread head migration that can be used when we know migration is not needed, as in, it's already been run. This should greatly reduce the time to deploy.
- I started updating libp2p to 0.15.1, which requires an update to go-datastore. Those changes require we wire context into all the datastore apis we use (keystore, logstore, db). I pushed that wip work to https://github.com/textileio/go-threads/tree/sander/libp2p-0.15.1. I think going down that path means a major version bump because the external DB apis would need to take context. Paused for now.
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Signed-off-by: Sander Pick <sanderpick@gmail.com>
merlinran
reviewed
Oct 29, 2021
| iter, err := newIterator(txn, t.collection.baseKey(), q) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
good catch! alternative if iterator needs to be instantiated everywhere we can make iterator methods always check for a nil value before doing stuff, but as it's used in only one place, this Go idiom is much simpler!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.