Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go-ds-mongo and account for errors in queries #682

Merged
merged 3 commits into from
Oct 19, 2020
Merged

Conversation

jsign
Copy link
Contributor

@jsign jsign commented Oct 19, 2020

Updates go-ds-mongo version which has bug fixes which caused panics in very unlucky situations of where the MongoDB database timeout.

Also, account for checking always errors in queries!

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign jsign added this to the Sprint 48 milestone Oct 19, 2020
@jsign jsign self-assigned this Oct 19, 2020
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign jsign marked this pull request as ready for review October 19, 2020 18:52
@jsign jsign requested a review from asutula October 19, 2020 18:52
Copy link
Member

@asutula asutula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@jsign jsign merged commit 4890c85 into master Oct 19, 2020
@jsign jsign deleted the jsign/fixx branch October 19, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants