Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client/CLI simplifications and improvements #686

Merged
merged 6 commits into from
Oct 21, 2020
Merged

Client/CLI simplifications and improvements #686

merged 6 commits into from
Oct 21, 2020

Conversation

asutula
Copy link
Member

@asutula asutula commented Oct 20, 2020 •
edited
Loading

This PR is targeting my asutula/deal-insight branch, goal being to accumulate big changes into that PR and do one big breaking release.

Main goal of this one is to simplify and standardize the client api and cli.

  • Client methods always return gRPC types, no more converting back to the various go types we use on the back end. This keeps the client feeling simple, reduced dependencies on the consumer of the client, and provides encoding/decoding to/from json that should be more consistent across platforms/languages.
  • The CLI is simplified, and in most cases simply just prints out the json version of the object received from the client. Removed spinners and other fancy stuff. This could all be considered a regression in some ways, but I think it's a better fit for the current state of the pow cli... We have some users that are having trouble scripting pow commands because of the spinners etc, and simply printing the data, all the data, fulfills the general need for maximum information possible in these crazy times of bugs and network instability.

Lots of files changed, but those types of changes are the only things that were done.

@asutula asutula self-assigned this Oct 20, 2020
@asutula
put back SendFil
21fb055 
Signed-off-by: Aaron Sutula <hi@asutula.com>
@asutula
docs
b41b520 
Signed-off-by: Aaron Sutula <hi@asutula.com>
@asutula
Merge branch 'asutula/deal-insight' into asutula/simple-client
c95fb38
@asutula asutula requested a review from jsign October 21, 2020 15:43
@asutula asutula marked this pull request as ready for review October 21, 2020 15:43
jsign
jsign approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asutula asutula merged commit d363b94 into asutula/deal-insight Oct 21, 2020
@asutula asutula deleted the asutula/simple-client branch October 21, 2020 16:06
@asutula asutula mentioned this pull request Oct 21, 2020
Merged
asutula added a commit that referenced this pull request Nov 4, 2020
@asutula @jsign
Deal Insight + New API Foundation (#659)
363d03b 
* represent deal states with enum

Signed-off-by: Aaron Sutula <hi@asutula.com>

* bubble up deal status changes

Signed-off-by: Aaron Sutula <hi@asutula.com>

* lock access to cache

Signed-off-by: Aaron Sutula <hi@asutula.com>

* typo and indent fix

Signed-off-by: Aaron Sutula <hi@asutula.com>

* pr feedback, send StorageDealInfo updates

Signed-off-by: Aaron Sutula <hi@asutula.com>

* little cleanup for pr feedback

Signed-off-by: Aaron Sutula <hi@asutula.com>

* move job monitoring inside job store, extend api to client and cli

Signed-off-by: Aaron Sutula <hi@asutula.com>

* better chan handling and locking

Signed-off-by: Aaron Sutula <hi@asutula.com>

* table output improvements

Signed-off-by: Aaron Sutula <hi@asutula.com>

* fixed table output

Signed-off-by: Aaron Sutula <hi@asutula.com>

* user protojson

Signed-off-by: Aaron Sutula <hi@asutula.com>

* seeing how raw json output feels

Signed-off-by: Aaron Sutula <hi@asutula.com>

* raw grpc and json for net client and cli

Signed-off-by: Aaron Sutula <hi@asutula.com>

* caches galore

Signed-off-by: Aaron Sutula <hi@asutula.com>

* expose data in api, tests

Signed-off-by: Aaron Sutula <hi@asutula.com>

* remove func options, add api to sched and ffs

Signed-off-by: Aaron Sutula <hi@asutula.com>

* admin service, client code

Signed-off-by: Aaron Sutula <hi@asutula.com>

* fix some tests

Signed-off-by: Aaron Sutula <hi@asutula.com>

* remove redundant token flag, ffs client and cl for job queries

Signed-off-by: Aaron Sutula <hi@asutula.com>

* better method naming

Signed-off-by: Aaron Sutula <hi@asutula.com>

* all sorts of work

Signed-off-by: Aaron Sutula <hi@asutula.com>

* update docs

Signed-off-by: Aaron Sutula <hi@asutula.com>

* fixed some array building

Signed-off-by: Aaron Sutula <hi@asutula.com>

* new general service

Signed-off-by: Aaron Sutula <hi@asutula.com>

* update lotus to v0.10.0

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* admin token

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* revert cidinfo name refactor

Signed-off-by: Aaron Sutula <hi@asutula.com>

* include tests

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* docs update

Signed-off-by: Aaron Sutula <hi@asutula.com>

* cleaning up a few things

Signed-off-by: Aaron Sutula <hi@asutula.com>

* revert net changes for now

Signed-off-by: Aaron Sutula <hi@asutula.com>

* fix net test

Signed-off-by: Aaron Sutula <hi@asutula.com>

* organizing services

Signed-off-by: Aaron Sutula <hi@asutula.com>

* clean up admin auth

Signed-off-by: Aaron Sutula <hi@asutula.com>

* fix some tests, admin cli

Signed-off-by: Aaron Sutula <hi@asutula.com>

* use wallet module in powergate service

Signed-off-by: Aaron Sutula <hi@asutula.com>

* finish merge

Signed-off-by: Aaron Sutula <hi@asutula.com>

* update docs, couple nits

Signed-off-by: Aaron Sutula <hi@asutula.com>

* clean up some nits, use new powergate service for balance, client/cli for storage config by job id

Signed-off-by: Aaron Sutula <hi@asutula.com>

* docs

Signed-off-by: Aaron Sutula <hi@asutula.com>

* remove locks

Signed-off-by: Aaron Sutula <hi@asutula.com>

* correct locking

Signed-off-by: Aaron Sutula <hi@asutula.com>

* pr feedback

Signed-off-by: Aaron Sutula <hi@asutula.com>

* just continue in case of job query error

Signed-off-by: Aaron Sutula <hi@asutula.com>

* Client/CLI simplifications and improvements (#686)

* use basic types and return grpc types

Signed-off-by: Aaron Sutula <hi@asutula.com>

* update cli, output json most of the time, better json

Signed-off-by: Aaron Sutula <hi@asutula.com>

* put back SendFil

Signed-off-by: Aaron Sutula <hi@asutula.com>

* docs

Signed-off-by: Aaron Sutula <hi@asutula.com>

* Storage profiles with tokens (#688)

* storage profiles with tokens

Signed-off-by: Aaron Sutula <hi@asutula.com>

* comment export

Signed-off-by: Aaron Sutula <hi@asutula.com>

* return AuthEntry from Create

Signed-off-by: Aaron Sutula <hi@asutula.com>

* Repurpose CidInfo (#689)

* rename cidinfo to storageinfo

Signed-off-by: Aaron Sutula <hi@asutula.com>

* rename ciddata to cidinfo

Signed-off-by: Aaron Sutula <hi@asutula.com>

* docs

Signed-off-by: Aaron Sutula <hi@asutula.com>

* API Re-org (#690)

* move buildinfo service to new foundation

Signed-off-by: Aaron Sutula <hi@asutula.com>

* remove health module, rpc, client, cli

Signed-off-by: Aaron Sutula <hi@asutula.com>

* remove indexes and reputation apis

Signed-off-by: Aaron Sutula <hi@asutula.com>

* remove net module and api

Signed-off-by: Aaron Sutula <hi@asutula.com>

* fix proto formatting

Signed-off-by: Aaron Sutula <hi@asutula.com>

* remove pay channel code

Signed-off-by: Aaron Sutula <hi@asutula.com>

* remove wallet module rpc, move wallet methods to admin api

Signed-off-by: Aaron Sutula <hi@asutula.com>

* add wallet admin apis to client and cli

Signed-off-by: Aaron Sutula <hi@asutula.com>

* set wm

Signed-off-by: Aaron Sutula <hi@asutula.com>

* move ffs rpc to powergate proto, update client

Signed-off-by: Aaron Sutula <hi@asutula.com>

* update runner

Signed-off-by: Aaron Sutula <hi@asutula.com>

* update cli

Signed-off-by: Aaron Sutula <hi@asutula.com>

* future proofing some api names

Signed-off-by: Aaron Sutula <hi@asutula.com>

* Make config commands top level

Signed-off-by: Aaron Sutula <hi@asutula.com>

* remove extra line

Signed-off-by: Aaron Sutula <hi@asutula.com>

* remove some ffs wording

Signed-off-by: Aaron Sutula <hi@asutula.com>

* more ffs word removal

Signed-off-by: Aaron Sutula <hi@asutula.com>

* update pow docs

Signed-off-by: Aaron Sutula <hi@asutula.com>

* fix auth context

Signed-off-by: Aaron Sutula <hi@asutula.com>

* update readme docs

Signed-off-by: Aaron Sutula <hi@asutula.com>

* api categories for config and data

Signed-off-by: Aaron Sutula <hi@asutula.com>

* better admin client and cli structure

Signed-off-by: Aaron Sutula <hi@asutula.com>

* update wallet type default

Signed-off-by: Aaron Sutula <hi@asutula.com>

* fix up client tests

Signed-off-by: Aaron Sutula <hi@asutula.com>

* fix formatting

Signed-off-by: Aaron Sutula <hi@asutula.com>

* cleaning up wallet api names

Signed-off-by: Aaron Sutula <hi@asutula.com>

* better naming for list methods

Signed-off-by: Aaron Sutula <hi@asutula.com>

* Better names for client jobs methods

Signed-off-by: Aaron Sutula <hi@asutula.com>

* profile id naming

Signed-off-by: Aaron Sutula <hi@asutula.com>

* clean up job id name in api

Signed-off-by: Aaron Sutula <hi@asutula.com>

* cleaning up some other api names

Signed-off-by: Aaron Sutula <hi@asutula.com>

* better name for storage profile id

Signed-off-by: Aaron Sutula <hi@asutula.com>

* better client options for admin storage jobs

Signed-off-by: Aaron Sutula <hi@asutula.com>

* clean up logging

Signed-off-by: Aaron Sutula <hi@asutula.com>

* introducing strings to some fil amounts

Signed-off-by: Aaron Sutula <hi@asutula.com>

* change balance and sendfil over to big int

Signed-off-by: Aaron Sutula <hi@asutula.com>

* better proto name for address type

Signed-off-by: Aaron Sutula <hi@asutula.com>

Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsign jsign jsign approved these changes

Assignees

@asutula asutula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asutula @jsign