Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bucket init from Cid, add IPFS UnixFS in local bucket, SetHead API, update Powergate #231

Merged
merged 21 commits into from
Jun 11, 2020
Merged

bucket init from Cid, add IPFS UnixFS in local bucket, SetHead API, update Powergate #231

merged 21 commits into from
Jun 11, 2020

Conversation

jsign
Copy link
Contributor

@jsign jsign commented Jun 9, 2020 •
edited
Loading

This PR is adding three features:

  • A new flag for init-ing a bucket with buck init --cid, which will create a bucket with bootstrap data from the provided <cid>. This Cid is a UnixFS DAG in the IPFS network.
  • Adding content to an existing bucket from the IPFS network. buck add <cid> <path>.
  • A new API for setting an IPFS UnixFS DAG at an arbitrary path in an existing bucket.

Also, it updates to newest version of Powergate and lotus-devnet.

Close #188

jsign added 2 commits June 8, 2020 22:33
@jsign
use new powergate, and devnet
8b24289 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
fixes
a09b572 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign jsign added this to the Sprint 38 milestone Jun 9, 2020
@jsign jsign self-assigned this Jun 9, 2020
jsign added 6 commits June 9, 2020 18:05
@jsign
init with cid test
9715c8c 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
remove seed
0987cbb 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
revert test change
fa28e3e 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
bootstrap cid bucket impl
98d86c4 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
buck init cli
ff02b5f 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
lints
db547a7 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign jsign changed the title buckets: reset arbitrary path to Cid buckets: bootstrap from Cid, merge with Cid Jun 10, 2020
@jsign jsign changed the title buckets: bootstrap from Cid, merge with Cid Bootstrap bucket from IPFS UnixFS cid, Add IPFS UnixFS in local bucket, update Powergate Jun 10, 2020
@jsign
buck add impl
7bec410 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign added 10 commits June 10, 2020 12:59
@jsign
fix print msg
d346c38 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
parallelize
5485961 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
tests
6584d65 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
new SetPath API
7deee48 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
improve impl and tests
6c3280a 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
improve comment
8625ccf 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
rename option
c0cf92a 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
fmt
49020f2 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
remove empty line
91ecc20 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
improve flag description
b91b4f8 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
jsign commented Jun 10, 2020
View reviewed changes
api/buckets/client/client.go Show resolved Hide resolved
api/buckets/client/client.go Show resolved Hide resolved
api/buckets/client/client_test.go Show resolved Hide resolved
api/buckets/client/client_test.go Show resolved Hide resolved
api/buckets/client/client_test.go Show resolved Hide resolved
api/buckets/service.go Show resolved Hide resolved
api/buckets/service.go Show resolved Hide resolved
cmd/buck/cli/add.go Outdated Show resolved Hide resolved
cmd/buck/cli/add.go Show resolved Hide resolved
cmd/buck/cli/init.go Show resolved Hide resolved
@jsign jsign requested a review from sanderpick June 10, 2020 20:21
@jsign jsign marked this pull request as ready for review June 10, 2020 20:21
jsign
jsign commented Jun 10, 2020
View reviewed changes
go.mod Show resolved Hide resolved
@jsign
clean gomod
67e1031 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
jsign commented Jun 10, 2020
View reviewed changes
go.mod Show resolved Hide resolved
@jsign jsign changed the title Bootstrap bucket from IPFS UnixFS cid, Add IPFS UnixFS in local bucket, update Powergate bucket init from Cid, add IPFS UnixFS in local bucket, SetHead API, update Powergate Jun 10, 2020
sanderpick
sanderpick approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Didn't see any issues 🔥 Happy to have an extra set of eyes in the buck command.

api/buckets/client/client.go Show resolved Hide resolved
api/buckets/pb/buckets.proto Show resolved Hide resolved
api/buckets/client/client_test.go Show resolved Hide resolved
api/buckets/pb/buckets.proto Show resolved Hide resolved
api/buckets/service.go Show resolved Hide resolved
api/buckets/service.go Show resolved Hide resolved
cmd/buck/cli/add.go Outdated Show resolved Hide resolved
cmd/buck/cli/init.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
@jsign
replace Ignore with Skip
2d545f5 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign jsign merged commit d6c3b71 into master Jun 11, 2020
@jsign jsign deleted the jsign/buckfeed branch June 11, 2020 11:48
@jsign jsign mentioned this pull request Jun 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderpick sanderpick sanderpick approved these changes

Assignees

@jsign jsign

Labels
None yet
Projects
None yet
Milestone
Sprint 38
Development

Successfully merging this pull request may close these issues.

Push existing IPFS cid to a bucket
2 participants
@jsign @sanderpick