fix: リンクの後にスペースを強制する処理が正常に動作していない不具合を修正 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
reviewed
May 6, 2021
| @@ -119,6 +119,34 @@ tester.run("Link周りのスペース", rule, { | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
| text: "これは[README](./README.md)おかしい", | |||
| output: "これは [README](./README.md)おかしい", | |||
There was a problem hiding this comment.
textの内容を書いたらoutputの内容になるという感じにテストですね。
There was a problem hiding this comment.
この場合はbefore: true なので前にスペースを入れる結果になれば正しいと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26 と同じように、
textlint-rule-ja-space-around-linkにて、after: trueを設定したうえでリンクの後にスペースを入れなくてもエラーが発生しない問題を修正しました。昨日ご教示頂いたコードを参考にテストコードを書いたのですが、これで正しいのか自信が持てておりません。問題があればご指摘いただけたらと思います。
よろしくお願いいたします。