Merge pull request #44 from cadurosar/cadurosar-patch-1

Fix small bug on splade
texttron · May 30, 2022 · 2eb0472 · 2eb0472
2 parents 76b3582 + ca210a1
commit 2eb0472
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/examples/splade/train_splade.py b/examples/splade/train_splade.py
@@ -40,7 +40,7 @@ def compute_loss(self, model, inputs):
         p_reps = output.p_reps
         loss = output.loss
         q_flops_loss = self.args.q_flops_loss_factor*self._flops(q_reps)
-        p_flops_loss = self.args.q_flops_loss_factor*self._flops(p_reps)
+        p_flops_loss = self.args.p_flops_loss_factor*self._flops(p_reps)
         if self.args.negatives_x_device:
             q_flops_loss *= self.world_size
             p_flops_loss *= self.world_size