Theme::replace could enter an infinite loop since commit c68749b (5 d…

…ays ago)

changelog.md

@@ -1,6 +1,7 @@
 TGUI 1.4.1  (TBD)
 -----------------
 
+- Fixed infinite loop in Theme::replace (introduced in TGUI 1.4.0)
 - PanelListBox now has proper background color and borders in White theme
 
 

src/Loading/Theme.cpp

@@ -721,7 +721,10 @@ namespace tgui
         for (auto pair : m_renderers)
         {
             const auto& renderer = pair.second;
-            for (auto& observer : renderer->observers)
+
+            // Make a copy of the observers because setRenderer alters the observers
+            auto observers = renderer->observers;
+            for (auto* observer : observers)
                 observer->setRenderer(renderer);
         }