Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PanelListBox to gui builder and add missing setItemsWidth function to PanelListBox #240

Merged
merged 1 commit into from
May 8, 2024

Conversation

Schweini07
Copy link
Contributor

I've noticed that there is no PanelListBox widget in the gui builder, so this PR adds it 🙂.

I also noticed that PanelListBox has a getItemsWidth function, but no setItemsWidth function. A getItemsHeight and a setItemsHeight function exist, so I assume this was just forgotten by the initial PR implementing it. Therefore I added this in a separate commit.

@texus
Copy link
Owner

texus commented May 8, 2024

ItemsWidth was intentionally not implemented. The panels are stacked below each other, and you are free to choose the panel height / item height, but the width is always equal to the list box width.

@Schweini07 Schweini07 force-pushed the panel-list-box-gui-builder branch from ebf0291 to 8ff477e Compare May 8, 2024 20:48
@Schweini07
Copy link
Contributor Author

Ah, I understand. I've rebased the commit now, so only the gui builder functionality remains 👍

@texus
Copy link
Owner

texus commented May 8, 2024

I didn't implement the widget in the gui builder myself because there wasn't much you could do at design time, but at least now you can give it a position and size in the gui builder.

The CI failed because I pushed some bad commits around the time you made this PR, but once merged everything should be fine.

@texus texus merged commit 2caf86a into texus:1.x May 8, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants