Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General improvements #1

Merged
merged 1 commit into from
Jun 5, 2022
Merged

General improvements #1

merged 1 commit into from
Jun 5, 2022

Conversation

Alex-1000
Copy link
Contributor

  • Sourcemod folder search now should work for Linux too
  • Library imports have been edited to only import parts that are used in code
  • Descriptions were written for functions
  • Program asks for OS name only once now
  • "message" and "message_quick" were merged into single function
  • Some messages were merged together
  • "message_yes_no" now has default answer option

@Alex-1000
Copy link
Contributor Author

i forgot to sort libraries in some files, standard libraries are usually put above program's own

@Technochips Technochips self-requested a review June 4, 2022 12:37
Technochips
Technochips approved these changes Jun 4, 2022
View reviewed changes
Copy link
Member

@Technochips Technochips left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now looks pretty good. Merging message_quick with message is also pretty good. We're planning on using the same functions to be able to actually show a GUI.

gui.py
ans = input(msg + " (Y/N)>").lower()

if ans == "y":
def message_yes_no(msg:str, default = true):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I like this when people could accidentally put in an invalid answer, then the program just chooses it for them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

Technochips
Technochips reviewed Jun 4, 2022
View reviewed changes
Copy link
Member

@Technochips Technochips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to note that we're currently looking to use the registry.vdf file to get the sourcemods path on Linux.

@chloecormier
Copy link
Collaborator

LGTM, sorry for the wait. Even though some solutions are kind of dirty (like manually combing through possible paths for the sourcemods folder on Linux, which won't work for Flatpak, Snap, server installs using steamcmd...), we can improve on that after it's merged.

@chloecormier chloecormier merged commit 08bdd0b into tf2classic:main Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technochips Technochips Technochips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alex-1000 @chloecormier @Technochips