Spring cleaning #229
Merged
Spring cleaning #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfausak
commented
Mar 13, 2021
| @@ -153,5 +153,5 @@ jobs: | |||
| with: | |||
| context: docker | |||
| file: docker/Dockerfile | |||
| tags: taylorfausak/rattletrap:version-${{ github.event.release.tag_name }} | |||
| tags: taylorfausak/rattletrap:${{ github.event.release.tag_name }} | |||
There was a problem hiding this comment.
This should be communicated in the change log.
| @@ -10,3 +10,48 @@ | |||
| - ignore: { name: Use <|> } | |||
| - ignore: { name: Use lambda-case } | |||
| - ignore: { name: Use <$> } | |||
| - modules: | |||
There was a problem hiding this comment.
I would like to start with allowing nothing and then selectively adding things, but doing that is blocked by ndmitchell/hlint#1221. It would be really tedious to do without name: Rattletrap*.
| @@ -2,3 +2,4 @@ FROM ubuntu:20.04 | |||
| RUN apt-get update && apt-get install --assume-yes ca-certificates | |||
| COPY rattletrap /usr/local/bin | |||
| RUN chmod +x /usr/local/bin/rattletrap | |||
| ENTRYPOINT ["rattletrap"] | |||
There was a problem hiding this comment.
This should also be communicated in the change log.
tfausak
commented
Mar 13, 2021
| case Config.output config of | ||
| Nothing -> LazyByteString.putStr json | ||
| Just file -> LazyByteString.writeFile file json | ||
| schemaMain config = putOutput config $ encodeJson config schema |
There was a problem hiding this comment.
As a result of this change, you can generate a compact schema with rattletrap --schema --compact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some little things that didn't really fit anywhere else.