Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory limit and overflow checking #16

Merged
merged 11 commits into from
Jun 24, 2022
Merged

Conversation

smaznet
Copy link
Contributor

@smaznet smaznet commented Oct 1, 2021

No description provided.

Copy link
Member

@vrumger vrumger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use snakeCase for variable names.

@rojvv
Copy link
Member

rojvv commented Oct 1, 2021

@AndrewLaneX it is fixed

src/stream.ts Outdated
private _readablePaused = false;
remoteTime?: RemotePlayingTimeCallback;
remoteLagging?: RemoteLaggingCallback;
overflowCallback?: (pause: boolean) => void;
Copy link
Member

@vrumger vrumger Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for? It doesn't seem to be used anywhere.

Copy link
Contributor Author

@smaznet smaznet Jun 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of codes was from @Laky-64 project
it was for lipSync but i didn't added lipSync feature
so in my implementation i didn't use that variables

original source: https:///pytgcalls/pytgcalls/blob/master/src/stream.ts

Copy link
Member

@vrumger vrumger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vrumger vrumger merged commit e03d7c4 into tgcallsjs:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants