-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate write acknowledge and write strobe generation #49
Separate write acknowledge and write strobe generation #49
Conversation
The write acknowledge signal is now combinatorically linked to the write request signal. The write strobe signal (that should become active only after the register is updated) is delayed by one cycle as previously.
@tgingold-cern to add to the following point:
Any write request relaying on the write acknowledge signal is now one cycle faster. About APB, we previously used |
Thanks! |
Probably you should add a line in README.MD to mention this change. |
Done in #51. |
The write acknowledge signal is now combinatorically linked to the write request signal. The write strobe signal (that should become active only after the register is updated) is delayed by one cycle as previously.
This allows for consecutive single cycle writes as mentioned in #48.
Since this pull request changes the write acknowledge signal to be asserted one cycle earlier, existing memory maps might execute their write requests one cycle faster now. If the default
pipeline
setting (wr-in,rd-out
) was used, while being faster the interfaces should still behave correctly. Required testbench changes are visible in 071dbb7 and affect only register write verification's happening now slightly too early (just around the rising edge where previously, the write request took one cycle longer and so the verification was also happening only one cycle later).Closes #48.