Skip to content

Commit

Permalink
Merge pull request #28 from ksickbert-iscope/development
Browse files Browse the repository at this point in the history
Development - fix for elements which already have a transform directive in css
  • Loading branch information
tgomilar committed Feb 27, 2018
2 parents 026086d + 0b1a7e9 commit 961998f
Showing 1 changed file with 17 additions and 12 deletions.
29 changes: 17 additions & 12 deletions dist/jquery.paroller.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,22 @@
bgHorizontal: function (elem, bgOffset) {
return elem.css({'background-position': -bgOffset + 'px' + ' center'});
},
vertical: function (elem, elemOffset) {
vertical: function (elem, elemOffset, oldTransform) {
(oldTransform === 'none' ? oldTransform = '' : true);
return elem.css({
'-webkit-transform': 'translateY(' + elemOffset + 'px)',
'-moz-transform': 'translateY(' + elemOffset + 'px)',
'transform': 'translateY(' + elemOffset + 'px)',
'-webkit-transform': 'translateY(' + elemOffset + 'px)' + oldTransform,
'-moz-transform': 'translateY(' + elemOffset + 'px)' + oldTransform,
'transform': 'translateY(' + elemOffset + 'px)' + oldTransform,
'transition': 'transform linear',
'will-change': 'transform'
});
},
horizontal: function (elem, elemOffset) {
horizontal: function (elem, elemOffset, oldTransform) {
(oldTransform === 'none' ? oldTransform = '' : true);
return elem.css({
'-webkit-transform': 'translateX(' + elemOffset + 'px)',
'-moz-transform': 'translateX(' + elemOffset + 'px)',
'transform': 'translateX(' + elemOffset + 'px)',
'-webkit-transform': 'translateX(' + elemOffset + 'px)' + oldTransform,
'-moz-transform': 'translateX(' + elemOffset + 'px)' + oldTransform,
'transform': 'translateX(' + elemOffset + 'px)' + oldTransform,
'transition': 'transform linear',
'will-change': 'transform'
});
Expand Down Expand Up @@ -68,6 +70,9 @@
var bgOffset = Math.round(offset * factor);
var transform = Math.round((offset - (windowHeight / 2) + height) * factor);

/* Transform directive of element before paroller */
var oldTransform = $this.css('transform');

if (type == 'background') {
if (direction == 'vertical') {
setDirection.bgVertical($this, bgOffset);
Expand All @@ -78,10 +83,10 @@
}
else if (type == 'foreground') {
if (direction == 'vertical') {
setDirection.vertical($this, transform);
setDirection.vertical($this, transform, oldTransform);
}
else if (direction == 'horizontal') {
setDirection.horizontal($this, transform);
setDirection.horizontal($this, transform, oldTransform);
}
}

Expand All @@ -107,10 +112,10 @@
}
else if ((type == 'foreground') && (scrolling <= documentHeight)) {
if (direction == 'vertical') {
setDirection.vertical($this, transform);
setDirection.vertical($this, transform, oldTransform);
}
else if (direction == 'horizontal') {
setDirection.horizontal($this, transform);
setDirection.horizontal($this, transform, oldTransform);
}
}

Expand Down

0 comments on commit 961998f

Please sign in to comment.