Skip to content
This repository has been archived by the owner on Jul 17, 2021. It is now read-only.

Update calendar-ui package, add localization settinsg if calendar plugin isn't installed #34

Merged
merged 3 commits into from
Jan 30, 2021

Conversation

liamcain
Copy link
Contributor

My very basic/dumb approach to localization here is:

if the calendar plugin is installed, use those settings. If not, show localization settings within slated.

It's far from optimal but it is at least functional. Open to ideas for a better approach!

yarn.lock Outdated Show resolved Hide resolved
@tgrosinger
Copy link
Owner

Ah shoot, yeah the rrule package is a mess right now. I am using a branch from a fork because it has a required bug fix that the maintainer has not yet merged in. Let me see if I can have npm use that forks commit hash instead of the NPM published version.

src/main.ts Outdated Show resolved Hide resolved
@tgrosinger
Copy link
Owner

If you rebase this on the main branch it should become mergable. I don't seem to be able to do that myself.

@liamcain liamcain force-pushed the upgrade-calendar-ui branch from 2bd617e to a9bb991 Compare January 30, 2021 18:54
@tgrosinger tgrosinger merged commit 4d00a7a into tgrosinger:main Jan 30, 2021
@tgrosinger
Copy link
Owner

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants