Guard against users using relative pathing to set the project name to the .dme in the repository #1835
+149
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
added
Client
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Cyberboss
added
the
Security
Cyberboss
force-pushed
the
BarGoesUpInFlames
branch
from
e6ae185
to
7981829
Compare
Cyberboss
force-pushed
the
BarGoesUpInFlames
branch
from
7981829
to
782c8d4
Compare
Cyberboss
force-pushed
the
BarGoesUpInFlames
branch
from
002e5ac
to
80e3d03
Compare
Cyberboss
force-pushed
the
BarGoesUpInFlames
branch
from
80e3d03
to
3acd25e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1835 +/- ##
==========================================
- Coverage 95.97% 95.95% -0.02%
==========================================
Files 713 713
Lines 163357 163366 +9
Branches 3229 3226 -3
==========================================
- Hits 156784 156762 -22
- Misses 6085 6114 +29
- Partials 488 490 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs I shouldn't have to make.
🆑
You can no longer deploy a .dme file outside of the deployment directory.
Fixed Windows path normalization applying to Linux instances in the same swarm.
/🆑
🆑 HTTP API
Added ErrorCode 107 for if a deployment is attempted with a project outside the deployment directory.
/🆑