Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with themes? #4

Closed
jackfranklin opened this issue Jun 15, 2013 · 7 comments
Closed

Bug with themes? #4

jackfranklin opened this issue Jun 15, 2013 · 7 comments

Comments

@jackfranklin
Copy link

So on iTerm 2, with the Solarized theme, distra's logs are sort of invisible:

http://cl.ly/image/3j3p082l370k

This is probably an issue with my system but just thought I'd report it. Trying to do some investigating into the cause.

@tgvashworth
Copy link
Owner

Yeah I found the same – so I changed my theme! Really annoying, will see what I can do. PR welcome ;)

@jackfranklin
Copy link
Author

A bit of research led me to a lot of other people complaining about this.

See: mochajs/mocha#802 & altercation/solarized#164

iTerm2 has the contrast set to the lowest. If you increase this, you can see color code 90. Still not awesome, but works.

A fix that works explicitly for me is to set it to white using the npm colors module: jackfranklin@1742987

I don't think that's a good fix but it works for me, so I'm now running distra through my local copy & npm link. There must be a more generic solution.

@jackfranklin
Copy link
Author

Found it. It's an iTerm solarized contrast thing:

@jackfranklin
Copy link
Author

I don't understand why the colours are different in some of the logs compared to others, though 🐗

@tgvashworth
Copy link
Owner

Yeah I know what you mean – I have the contrast up but how did it come to be that they used the same colour for foreground and background?!

@jackfranklin
Copy link
Author

I've no idea what's happening here :(

@tgvashworth
Copy link
Owner

Meh. Closing cos this ain't a biggy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants