-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
color code 90 (dark gray) nearly invisible in osx terminal / iterm2 #164
Comments
That's intended, no? base02 is supposed to have low contrast with base03. |
i'm only trying to say that many applications use it as a foreground color (because normally dark gray would be amply visible against either black or white), and so that it should have sufficient contrast against the default background to be legible. as it is now it is not the case. |
iTerm2 has the contrast set to the lowest. If you increase this, you can see color code 90. Still not awesome, but works. |
i think this is a dup of #8 |
@cgarvis That's a pretty good solution - it should be added to the iterm2-solarized |
Related: mochajs/mocha#802 |
Contrast fixed it for me, thanks @cgarvis ! |
After reading for more than 30 mins for solutions this is the best one! +100 |
👍 Increase contrast a little fixed it. |
This indeed fixes the problem for me, is there any way this could be made the default value or explained somewhere in the README? Took a while to figure this out, nearly stopped using solarized :/ |
Ditto @foxx |
@foxx Unless there's a hidden value for the itermcolors file format, exporting after changing the contrast seems to indicate that the contrast setting is not part of the itermcolors file and cannot be defaulted. |
Contrast fixed it for me, thanks @cgarvis ! |
@cgarvis: Thank you from the future! ❤️ |
@cgarvis: Thank you. Contrast fixed it. |
@cgarvis awesome, thanks! |
Changing the contrast breaks Bullet Train. |
this was fixed in vscode microsoft/vscode#146243 |
color code 90 (dark gray) is nearly invisible in osx terminal / iterm2.
in a "standard" terminal palette this code shows as dark gray. but in dark solarized it is almost exactly the same as the background color.
The text was updated successfully, but these errors were encountered: