Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color fix needed? #220

Open
hemanth opened this issue Sep 12, 2012 · 133 comments
Open

Color fix needed? #220

hemanth opened this issue Sep 12, 2012 · 133 comments

Comments

@hemanth
Copy link

hemanth commented Sep 12, 2012

color

That's how it looks in my terminal, can read the text only after highlighting them!

The color of the text is gray!

@sindresorhus
Copy link

This is the grey color that is turned invisible: \x1B[90m

@sindresorhus
Copy link

@altercation @TrevorBramble bump. A lot of people are experiencing this bug...

@altercation
Copy link
Owner

What's generating this prompt?

(Yes, this is a significant issue. I want to test and repo)

@sindresorhus
Copy link

@altercation node-prompt, see here.

Also see the referenced issues above.

That text is invisible because the authors of Solarized Dark made the "bright black" color the same color as the background. Whoops. Also, for some reason, they made almost all of the "bright" colors not lighter, but darker than their "normal" counterparts.

@altercation
Copy link
Owner

So it's clear, this is not a "whoops" at all, but rather a very intentional and considered compromise based on the shitstorm of conflicting standards, expectations and legacy applications that is terminal emulation.

While a change is possible, and the information about which applications and programs suffer from issues like this is very helpful, it isn't going to happen immediately as any change is going to break the way something works.

This is probably the number one concern I have (the bright black issue) and I will only make a change once I'm certain it's the absolute best option.

@hellais
Copy link

hellais commented Oct 17, 2012

I was also experiencing this issue with yeoman, not sure on which side the bug should be fixed, but the workaround I found is to use this my Xresources

#define hack_color #1c1c1c
*color8: hack_color

Changing the value of color8 to hack_color (it used to be set to !!base03 #002b36)

@satazor
Copy link

satazor commented Nov 12, 2012

bump

@ghost
Copy link

ghost commented Nov 23, 2012

I'm having the issue with the output from an ExpressJS application.

@cobyism
Copy link

cobyism commented Jan 10, 2013

Just ran into (what I believe is) this issue with yeoman. Here’s what the yeoman usage/help command looks like in iTerm2 with Solarized Dark:

Screen Shot 2013-01-10 at 5 07 30 PM

…and with Solarized Light:

Screen Shot 2013-01-10 at 5 07 09 PM

@cobyism
Copy link

cobyism commented Jan 10, 2013

Another example is the usage command of bower.

Screen Shot 2013-01-10 at 5 22 44 PM
Screen Shot 2013-01-10 at 5 23 13 PM

@mleveck
Copy link

mleveck commented Jan 22, 2013

What is the status of this? I just installed Yeoman 0.9.6 and large chunks of text are invisible in iTerm 2 with solarized dark. I'd let it go but:

  1. My setup is far from uncommon. I'd say most OS X devs I know use iTerm2 and Solarized.
  2. By definition Yeoman is a tool to make life easier, so I'd hope that fixing things like this might be a bit of a priority.

@ghost
Copy link

ghost commented Jan 22, 2013

@mleveck You can look into the version in my pull request. Yeoman looks better with it...

Screen Shot 2013-01-21 at 7 59 14 PM

@necolas
Copy link

necolas commented Apr 29, 2013

Related problem in Mocha too - mochajs/mocha#802

@sindresorhus
Copy link

:/

@ghost
Copy link

ghost commented Apr 29, 2013

Other themes give me the same problems such as Tomorrow Night Bright at https://github.com/chriskempson/tomorrow-theme. Really annoying.

@paulirish
Copy link

@altercation can you please look into this.
Seems bad to advocate that people to abandon solarized but... 6 months in, we're just about at that point.

@altercation
Copy link
Owner

@paulirish Sure. I'll take a look.

@necolas
Copy link

necolas commented Jul 25, 2013

This problem is also affecting Express: expressjs/express#1700

Most of the popular front-end tools have been or are affected by this long-standing bug.

@sindresorhus
Copy link

This is just ridiculous...

@sheeit
Copy link

sheeit commented Nov 11, 2016

Here's a simple command to reproduce this:
if you have your terminal set up with the Solarized theme, just do

printf 'Normal text. \033[1;30mInvisible text\033[0m.\n'

The text "Invisible text" will not be visible.

solarized

@i-manolov
Copy link

i-manolov commented Jan 2, 2017

i hope there are plans to fix this. I noticed the problem when trying to use mocha for the first time after changing to the solarized theme in iTerm2. Here is my work around for the moment:

@kyeotic
Copy link

kyeotic commented Jul 13, 2017

@altercation Its been 4 years since you said you would take a look. Has there been any progress on this, or should we abandon solarized dark?

@icyflame
Copy link

hey @tyrsius, the possibility of this being fixed is remote. You should try using base16, I switched to that when I first encountered this issue and it's been pretty good. 😄

@jacoscaz
Copy link

@ivanmanolov90's solutions seems to works perfectly for me - at least with the tools I use.

@bobf
Copy link

bobf commented Oct 28, 2018

I "fixed" this by setting iTerm2's black light colour to 0387ad (as suggested by @ivanmanolov90 ) and then using the following settings:

set background=dark
let g:solarized_termtrans = 1
colorscheme solarized

I know this won't work for everyone but if your setup is like mine then maybe it'll save you 15 minutes of frustration.

@icyflame
Copy link

icyflame commented Oct 28, 2018

I copied over the colors from gnome-terminal to iTerm2 and created a new color scheme. here. I tried using both base16 and base256 for iTerm2, but the first one simply didn't show some text and the second one had a weird problem where the difference between folders and files was very small (they were both white and the difference in font weight was not noticeable at all)

I have been using this for a couple days now, and it's not shown up any problems. I will report here if it does.

P.S the copying over process was pretty simple and you should absolutely do it if you have a preferred setup on a computer that works fine and want to emulate the setup elsewhere. (Not sure if this was already discussed here, I was unable to find it anywhere) 🤔

@laggardkernel
Copy link

I copied over the colors from gnome-terminal to iTerm2 and created a new color scheme. here.

I see. You're using the normal colors as the bright ones. I'm going to do the same. At least, the bright colors are not grey anymore.

bmaupin added a commit to bmaupin/configs that referenced this issue Feb 16, 2022
…to (dark grey)

In most terminals it seems 'bright black' should be set to a grey/dark grey colour. Unfortunately this is a known issue with solarized since 2012 (altercation/solarized#220)
juanibiapina added a commit to juanibiapina/dotfiles that referenced this issue Jan 30, 2023
Many JS libraries do not work well with solarized: altercation/solarized#220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests