-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color fix needed? #220
Comments
This is the grey color that is turned invisible: |
@altercation @TrevorBramble bump. A lot of people are experiencing this bug... |
What's generating this prompt? (Yes, this is a significant issue. I want to test and repo) |
@altercation node-prompt, see here. Also see the referenced issues above.
|
So it's clear, this is not a "whoops" at all, but rather a very intentional and considered compromise based on the shitstorm of conflicting standards, expectations and legacy applications that is terminal emulation. While a change is possible, and the information about which applications and programs suffer from issues like this is very helpful, it isn't going to happen immediately as any change is going to break the way something works. This is probably the number one concern I have (the bright black issue) and I will only make a change once I'm certain it's the absolute best option. |
I was also experiencing this issue with yeoman, not sure on which side the bug should be fixed, but the workaround I found is to use this my Xresources #define hack_color #1c1c1c Changing the value of color8 to hack_color (it used to be set to !!base03 #002b36) |
bump |
I'm having the issue with the output from an ExpressJS application. |
Just ran into (what I believe is) this issue with yeoman. Here’s what the …and with Solarized Light: |
Another example is the usage command of bower. |
What is the status of this? I just installed Yeoman 0.9.6 and large chunks of text are invisible in iTerm 2 with solarized dark. I'd let it go but:
|
@mleveck You can look into the version in my pull request. Yeoman looks better with it... |
Related problem in Mocha too - mochajs/mocha#802 |
:/ |
Other themes give me the same problems such as Tomorrow Night Bright at https://github.com/chriskempson/tomorrow-theme. Really annoying. |
@altercation can you please look into this. |
@paulirish Sure. I'll take a look. |
This problem is also affecting Express: expressjs/express#1700 Most of the popular front-end tools have been or are affected by this long-standing bug. |
This is just ridiculous... |
i hope there are plans to fix this. I noticed the problem when trying to use mocha for the first time after changing to the solarized theme in iTerm2. Here is my work around for the moment:
|
@altercation Its been 4 years since you said you would take a look. Has there been any progress on this, or should we abandon solarized dark? |
hey @tyrsius, the possibility of this being fixed is remote. You should try using base16, I switched to that when I first encountered this issue and it's been pretty good. 😄 |
@ivanmanolov90's solutions seems to works perfectly for me - at least with the tools I use. |
I "fixed" this by setting iTerm2's
I know this won't work for everyone but if your setup is like mine then maybe it'll save you 15 minutes of frustration. |
I copied over the colors from gnome-terminal to iTerm2 and created a new color scheme. here. I tried using both base16 and base256 for iTerm2, but the first one simply didn't show some text and the second one had a weird problem where the difference between folders and files was very small (they were both white and the difference in font weight was not noticeable at all) I have been using this for a couple days now, and it's not shown up any problems. I will report here if it does. P.S the copying over process was pretty simple and you should absolutely do it if you have a preferred setup on a computer that works fine and want to emulate the setup elsewhere. (Not sure if this was already discussed here, I was unable to find it anywhere) 🤔 |
I see. You're using the normal colors as the bright ones. I'm going to do the same. At least, the bright colors are not grey anymore. |
…to (dark grey) In most terminals it seems 'bright black' should be set to a grey/dark grey colour. Unfortunately this is a known issue with solarized since 2012 (altercation/solarized#220)
Many JS libraries do not work well with solarized: altercation/solarized#220
…ackground The color is borrowed from https://github.com/jan-warchol/selenized/blob/master/terminals/alacritty/selenized-dark.yml#L16 Issue in solarized repo: altercation/solarized#220
That's how it looks in my terminal, can read the text only after highlighting them!
The color of the text is gray!
The text was updated successfully, but these errors were encountered: