Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix foreground color that has the same color as the background #240

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix foreground color that has the same color as the background #240

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2013

Replaced the light black with a gray instead of the dark blue which I believe is the same color as the background. This should solve #220, but I'm not 100% sure that I am using the right color.

Here's a screenshot of yeoman now:

Screen Shot 2013-01-21 at 7 59 14 PM

@sindresorhus
Copy link

@altercation @TrevorBramble bump. we've been waiting for a solution to #220 for half a year now...

@nocksock
Copy link

nocksock commented Apr 5, 2013

Unfortunately this fix breaks (at least) vim.

@ghost
Copy link
Author

ghost commented Apr 5, 2013

That’s odd. It doesn’t seem to do that on my end.

@ghost
Copy link
Author

ghost commented Apr 29, 2013

Yeah indeed, it seems to cause issues if you use vim (with the vim solarized dark colors) in iTerm2 (with my solarized fork).

I’m not sure then if the problem is with the iTerm2 or the vim theme. @TrevorBramble any ideas? Also, if you need any help dealing with all the PR maybe I can help a bit... not much activity in the repo lately.

Seems like my fix to the iTerm2 solarized theme causes some issues with
vim so I blindly tweaked the vim theme. Seems to work.
@ghost
Copy link
Author

ghost commented Apr 30, 2013

@noxoc I did a little tweak to the vim theme and at first glance it seems to do the trick. I’m no expert though. https://github.com/hydrozen/solarized/commit/13d13ea3ee5060c90baa650d6db7c2bd01dac33d

@mente
Copy link

mente commented Jul 8, 2013

bumping this thread in hope that this issue would be fixed

@megamaddu
Copy link

ditto - hydrozen's fork fixes both iterm2 and vim for me (using item2 dark and solarized.vim)

@ghost
Copy link
Author

ghost commented Jul 11, 2013

@spicydonuts cool! glad someone is using this :)

@mente
Copy link

mente commented Jul 11, 2013

would be better if was merged. What's the stopper?

@ghost
Copy link
Author

ghost commented Jul 12, 2013

I’m not sure, I’m not an expert in theme-making, but I feel like my forks are at the very least a step in the right direction in finding a solution.

@mente
Copy link

mente commented Jul 12, 2013

It can be used at least as workaround. @altercation @TrevorBramble guys, would be great if you merge it. Thanks :)

jeanlauliac and others added 2 commits December 21, 2013 21:44
Otherwise it is set to the light grey of the fixed Solarized and looks meh.
Force the background of SignColumn to none
@antoinelyset
Copy link

I think we need to consider an official fork of this repo. The maintainer doesn't seem to care about fixing this issues. I don't blame him, this is a huge work.

karlhorky added a commit to karlhorky/dotfiles that referenced this pull request Oct 20, 2014
@pgarrison pgarrison mentioned this pull request Feb 25, 2016
@wenwuwu
Copy link

wenwuwu commented Jun 16, 2016

Anyone tried to increase iTerm2 's contrast ? Light gray color becomes visible after increasing contrast a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants