Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gray text readable on Solarized Dark theme #118

Merged
merged 2 commits into from
Jun 14, 2017
Merged

Make gray text readable on Solarized Dark theme #118

merged 2 commits into from
Jun 14, 2017

Conversation

s0meone
Copy link
Contributor

@s0meone s0meone commented Jun 14, 2017

What was the problem/Ticket Number

Gray text is unreadable with Solarized Dark theme

How does this solve the problem?

Makes the text readable again

How to duplicate the issue

  1. Install Solarized Dark theme
  2. Run esw with simple-detail formatter
  3. Create an lint error
  4. Try to read the output in the terminal

See:
eslint/eslint#4885
altercation/solarized#220
chalk/chalk#40

Before
image

After
image

@rizowski
Copy link
Owner

@s0meone Thanks for the PR! Once I get my PR in, I'll need you to update your branch and then we can see about getting this in.

@rizowski rizowski merged commit a8924bd into rizowski:master Jun 14, 2017
@s0meone
Copy link
Contributor Author

s0meone commented Jun 14, 2017

Thanks! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants