🐛 Solarized Dark theme renders certain commands/text unreadable.

[MiniFlames]

Certain text is unreadable when using the 'Solarized Dark' theme, for example the following command in Powershell

pktmon start --etw -m real-time

is rendered like this:

Thus far I've only noticed the issue with Powershell commands.

---

Windows
Terminal Version(s): 0.11.1121.0 and 0.11.1333.0
Powershell Version: Powershell Core 7.0.0
Windows Version: Windows 10 - Insider Preview (Fast Ring), build 19268.

[skyline75489]

I've experienced this once with PSCore. Changing the color setting of PSCore itself (using Set-PSReadlineOption) effectively fix this. I'm not sure what we can do (or should do) on the terminal side.

[jdhitsolutions]

I have found that when using this theme I have to make sure not to set useAcrylic to false and remove the PSReadline module. The problem is the conflict between PSReadline options and the WT theme. I'm not sure that can be fixed. I'd say your best solution is to use Set-PSReadlineOption to adjust colors when using the Solarized Dark theme.

[jdhitsolutions]

This is the PowerShell script I run when I need to adjust colors.

#Update-PSReadline.ps1
# https://en.wikipedia.org/wiki/ANSI_escape_code

if ($IsCoreCLR) {
    $esc = "`e"
}
else {
    $esc = $([char]0x1b)
}

Set-PSReadLineOption -Colors @{
    Parameter = "$esc[96m"
    Operator  = "$esc[38;5;47m"
    comment   = "$esc[92m"
    String    = "$esc[38;5;51m"
}

[j4james]

This is a very old bug in the Solarized color scheme (altercation/solarized#220).

[DHowett-MSFT]

Yeah, this one is unfortunately by design. Solarized was not a good color scheme for us to ship by default, but here we are on the doorstep of v1 being sad about it. ☹️

[DHowett-MSFT]

FWIW: some combination of #2661 and #293 are at play here.