Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type changes at non-singleton nodes produce surprising output #42

Closed
tgvaughan opened this issue Sep 17, 2015 · 1 comment
Closed

Type changes at non-singleton nodes produce surprising output #42

tgvaughan opened this issue Sep 17, 2015 · 1 comment
Assignees

Comments

@tgvaughan
Copy link
Owner

For instance, the following pair of reactions:

     C:1 -> C:1 + R:1
     C:1 + R:1 -> C:1

will produce a tree on which the R type never appears, despite the actual topology being correct.

The reason behind this is as follows. In output files, node types are used to refer to type types along the edges immediately above those edges. This is convention replicated internally, where each node in an inheritance graph is associated with exactly one population. Clearly, however, this creates problems when a node has an in-degree greater than 1, as there is no way of keeping track of those edge types.

You might imagine that this problem is insurmountable as we are using Newick as our output type, but in fact the extended Newick representation provides a single unique node for every edge in the network.

The fix is therefore to allow inheritance graph nodes to keep track of the types of all incoming edges rather than just the type at the node.

tgvaughan added a commit that referenced this issue Sep 17, 2015
@tgvaughan
Copy link
Owner Author

This is actually quite difficult to solve, as edges aren't even uniquely identified by pairs of nodes - there may be more than one edge between a given node pair.

@tgvaughan tgvaughan self-assigned this Sep 18, 2015
tgvaughan added a commit that referenced this issue Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant