[Shortcuts] MPRIS fixes, Repeat Language bug fix #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araxeus
requested changes
Jan 28, 2023
|
LGTM (except the missing padding spaces inside curly braces, but that's just a style diff 😋) |
Araxeus
approved these changes
Jan 28, 2023
|
After some more testing I did find a bug: Sometimes when the volume is changed cpu usage will spike to 100% for a few seconds. Don't merge until I have fixed that. |
|
The reason the cpu sometimes spiked was that sometimes the mpris volume slider and the internal one got desynced and then recursively called the update function of the other. Its fixed now. |
th-ch
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MPRIS-Interface (Linux) has the range 0.0 - 1.0 for volume. It is also better to use the constants provided by the library. I changed the setupRepeatChangeListener() function because it returned the mode of the repeat of the music in the language that Youtube-Music has active, but because those strings are hard coded in mpris.js, it would break MPRIS if YT-music was set to another language. Thus I used the cookie set by YT-music to determine the repeat mode and mapped that to the english valuse since those were used in code.