Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PiP] Remove titlebar when in-app-menu is enabled #1024

Merged
merged 1 commit into from
Feb 12, 2023
Merged

[PiP] Remove titlebar when in-app-menu is enabled #1024

merged 1 commit into from
Feb 12, 2023

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Feb 10, 2023 •
edited
Loading

  • When PiP is enabled and also in-app-menu is enabled:

    • Hide the titlebar
    • Make the player (window) draggable
    • Make the player-bar not draggable (enable clicking the control buttons)
    • Declutter the player-bar by removing text info (track name, artist, etc), thumbnail and the menu button

  • Removed the in-app-menu adaptor since there's no point changing a menu that can't be seen
    in-app-menu-pip-no-titlebar

kinda wish we had Sass/scss set up, normal css is annoying sometimes 😅

@Araxeus
remove titlebar from in-app-menu+PiP
5dd8d1a 
Results in an experience similar to the native PiP, except plugins can work (for example precise-volume)
@Araxeus Araxeus changed the title remove titlebar from in-app-menu+PiP Remove titlebar from PiP when in-app-menu is enabled Feb 10, 2023
@Araxeus Araxeus changed the title Remove titlebar from PiP when in-app-menu is enabled [PiP] Remove titlebar when in-app-menu is enabled Feb 10, 2023
@th-ch th-ch merged commit 7df7b32 into th-ch:master Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Araxeus @th-ch