Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lyrics-genius] Fix lyrics not showing up or showing up when they shouldn't #1052

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Mar 2, 2023


  • add slight delay to lyrics genius

    this allows YouTube to finish doing what it needs (removing native lyrics / updating with new native ones)

    fix Lyrics from previous song remain when skipping #1041 and other lyrics issues

    instead of a 500ms timeout, it could setup an observer. but I think it's unreliable since sometimes youtube might have done it's job before the observer would be set up - and right now I don't have a better way to check if the job was done

@Araxeus
Copy link
Collaborator Author

Araxeus commented Mar 2, 2023

I love 3 lines changes that fixes alot of bugs 😋

this allows youtube to finish doing it's stuff

fix th-ch#1041 and other lyrics issues
@DereC4
Copy link
Contributor

DereC4 commented Mar 3, 2023

I'll update these in my pr as well

@DereC4
Copy link
Contributor

DereC4 commented Mar 3, 2023

Works; lyrics label also undims itself on its own without having to click on other parts of the menu

@@ -90,5 +90,5 @@ module.exports = () => {
tabs.lyrics.removeAttribute("disabled");
tabs.lyrics.removeAttribute("aria-disabled");
}
});
}, 500));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could be a file const

@th-ch th-ch merged commit 476b450 into th-ch:master Mar 8, 2023
@BiskottoScriptato
Copy link

i still have some troubles to make the lyrics show up, i have enabled lyrics genius in the plugin tab but i don't see them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Genius lyrics incorrect Lyrics from previous song remain when skipping
5 participants