Protocol handler arguments are not correctly parsed

[pathmann]

The last character from a protocol handler argument is removed, so the argument won't be parsed correctly to call the requested song control function.

So executing youtubemusic://playPause will be parsed to playPaus, on the other hand executing youtubemusic://playPauseX will trigger the playPause song control.

[Araxeus]

Hmm this is weird, it definitely works on my pc (Windows 10)

what OS are you on?

[pathmann]

(Gentoo) Linux 64 bit

What is the purpose (maybe only on Windows) of removing that last character?

[Araxeus]

Oh I see the problem now. on windows there is always an appended character - /

So we just need to check if it ends with /

btw we didn't catch this because the protocol-handler was originally added for interactive notifications which are windows only

Out of curiosity, might I ask what did you use the protocol handler for?
and also how did you know that the protocol handler exists?
and how did you understand the cause of the bug since it doesn't say anything when failing?😅

[pathmann]

I see.

Long story: I needed a possibility to like the current song from my stream deck, so I searched the code and issues for a way and found #946.

Your comment stated youtubemusic://pause as the way to go, so I thought this would be a bug, but I could also live with appending some suffix (like /)

[Araxeus]

The code just have to check if it ends with / like I said, this will fix all problems

If you don't want / can't do it yourself, just tell me and ill gladly open a PR

(btw you make me glad that I spend so much effort on PR descriptions ☺️)

[pathmann]

If you don't mind, sure. I'm not very experienced in Javascript 😁

[Araxeus]

Ok FYI next time you fork a repo to open a Pull Request – create a new branch first, don't open PR's from your default branch

[Araxeus]

I've opened a PR #1099 can you try it out?

just check this branch out https://github.com/Araxeus/youtube-music/tree/fix-protocol-handler-on-unix

[pathmann]

Yep, works.

Thanks a lot