Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugin auto-importer with vite-plugin-resolve #1385

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

JellyBrick
Copy link
Collaborator

@JellyBrick JellyBrick added the enhancement New feature or request label Nov 8, 2023
@ArjixWasTaken
Copy link
Contributor

Instead of having a named export, how about having a default export?

That way, you don't need to alias the imported constant every time.

@JellyBrick
Copy link
Collaborator Author

Instead of having a named export, how about having a default export?

That way, you don't need to alias the imported constant every time.

https://basarat.gitbook.io/typescript/main-1/defaultisbad

For the above reasons, I wanted to avoid using the default export. What do you think?

@ArjixWasTaken
Copy link
Contributor

Hmm, then what about having a different named export for each context?
Just like feat/codegen.

@JellyBrick
Copy link
Collaborator Author

JellyBrick commented Nov 8, 2023

Hmm, then what about having a different named export for each context? Just like feat/codegen.

  • Before I do this, I want to rename front.ts to renderer.ts and back.ts to main.ts.
    • (to clarify the context in which the plugin is running)
    • (frontPluginList -> rendererPluginList, backPluginList -> mainPluginList)
  • So, is it okay if I merge this pull request before doing a rename task?

@JellyBrick JellyBrick merged commit 59426c5 into master Nov 9, 2023
@JellyBrick JellyBrick deleted the feat/resolve branch November 9, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants