Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new plugin Album actions #1515

Merged
merged 19 commits into from
Dec 29, 2023
Merged

Conversation

MiepHD
Copy link
Contributor

@MiepHD MiepHD commented Dec 10, 2023

Adds Undislike, Dislike, Like and Unlike buttons to apply this to all songs in a playlist or album.
image
Fixes #831

@ArjixWasTaken
Copy link
Contributor

Don't add enabled: true in the config....
Your plugin must not be enabled unless specified otherwise by the user's config.

@MiepHD
Copy link
Contributor Author

MiepHD commented Dec 10, 2023

I enabled it by default because it just adds these buttons to the UI. If you don't click the buttons nothing happens. But I can remove that if that's a problem

@ArjixWasTaken
Copy link
Contributor

Since it does not fix a bug, I consider it an additional feature.
I guess I'll leave it up to @JellyBrick

@JellyBrick
Copy link
Collaborator

image

The shapes of the buttons can be confusing to users.

@MiepHD
Copy link
Contributor Author

MiepHD commented Dec 10, 2023

Why? Should I add an explanation what they do?

@JellyBrick
Copy link
Collaborator

What about showing just one of each button? (1 dislike button, 1 like button)

  • If any item is "Liked", show a filled "Like" button; if any item is "Disliked", show a filled "Dislike" button
  • If both "Liked" and "Disliked" are checked, show both filled buttons

@JellyBrick JellyBrick added the enhancement New feature or request label Dec 10, 2023
@MiepHD
Copy link
Contributor Author

MiepHD commented Dec 11, 2023

Now it shows a

  • undislike button if any item is disliked
  • dislike button if any item isn't disliked
  • like button if any item isn't liked
  • unlike button if any item is liked

src/plugins/album-actions/index.ts Outdated Show resolved Hide resolved
src/plugins/album-actions/index.ts Outdated Show resolved Hide resolved
src/plugins/album-actions/index.ts Show resolved Hide resolved
src/plugins/album-actions/index.ts Outdated Show resolved Hide resolved
src/plugins/album-actions/index.ts Outdated Show resolved Hide resolved
src/plugins/album-actions/index.ts Outdated Show resolved Hide resolved
@inson1
Copy link
Contributor

inson1 commented Dec 12, 2023

@MiepHD Great work!

Now it shows a

  • undislike button if any item is disliked
  • dislike button if any item isn't disliked
  • like button if any item isn't liked
  • unlike button if any item is liked

Just another opinion. I hope you dont mind :) That is standard, yes, but it isnt perfect :/.

What about highlighted (bold lines?) like/dislike button if some are liked/disliked, but not all? (I think that is also used somewhere in some app) Or something like that? Maybe like/dislike button with full white, but black "ball" inside?

Just something so normal user would get it and "profi" user would know if all songs are liked or disliked.
Or another mode for this?

@MiepHD MiepHD marked this pull request as draft December 22, 2023 15:25
MiepHD and others added 2 commits December 27, 2023 10:12
@MiepHD MiepHD marked this pull request as ready for review December 27, 2023 09:20
@MiepHD MiepHD requested a review from JellyBrick December 27, 2023 09:22
@JellyBrick JellyBrick changed the title Album actions feat: Add new plugin Album actions Dec 27, 2023
Copy link
Collaborator

@Su-Yong Su-Yong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems memory leak bug

src/plugins/album-actions/index.ts Show resolved Hide resolved
src/plugins/album-actions/index.ts Show resolved Hide resolved
@JellyBrick JellyBrick merged commit 5e79e9e into th-ch:master Dec 29, 2023
5 checks passed
@MiepHD MiepHD deleted the album-actions branch December 29, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Like all songs in an Album
5 participants