feat: Better Scrobbler Plugin #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It needs a migration script. see https://github.com/th-ch/youtube-music/blob/master/src/config/store.ts |
JellyBrick
requested changes
Jan 14, 2024
Is there a way to test migrations? I made one, but don't know how to try it out. |
JellyBrick
requested changes
Jan 15, 2024
Serial-ATA
force-pushed
the
better-scrobbler
branch
from
7d0442e to
57ef128
Compare
Co-authored-by: JellyBrick <shlee1503@naver.com>
Serial-ATA
force-pushed
the
better-scrobbler
branch
from
57ef128 to
4d07e98
Compare
JellyBrick
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the
last-fmplugin into the newscrobblerplugin.This currently supports Last.fm and ListenBrainz.
All translation strings for the
last-fmplugin had to be removed.Both services have their own configuration windows:
closes #1350